Skip to content

ENH: Add Python example for ConvolveImageWithKernel#453

Merged
hjmjohnson merged 2 commits into
mainfrom
rebase/convolve-image-with-kernel-python
Jun 15, 2026
Merged

ENH: Add Python example for ConvolveImageWithKernel#453
hjmjohnson merged 2 commits into
mainfrom
rebase/convolve-image-with-kernel-python

Conversation

@hjmjohnson

@hjmjohnson hjmjohnson commented Apr 17, 2026

Copy link
Copy Markdown
Member

Rebase of @PranjalSahu's PR #376 onto current main.

Adds a Python (Code.py) example for ConvolveImageWithKernel, complementing the existing C++ example.

@hjmjohnson hjmjohnson mentioned this pull request Apr 17, 2026
Closed
@github-actions github-actions Bot added type:Enhancement Improvement of existing methods or implementation area:Documentation Issues affecting the Documentation module area:Filtering Issues affecting the Filtering module type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots language:Python Changes to Python examples labels Apr 17, 2026
@hjmjohnson hjmjohnson force-pushed the rebase/convolve-image-with-kernel-python branch from f4ef9ec to 43dee2e Compare June 12, 2026 12:47
dzenanz
dzenanz reviewed Jun 12, 2026
View reviewed changes

@dzenanz dzenanz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good.

Comment thread src/Filtering/Convolution/ConvolveImageWithKernel/MatplotlibVisualizeConvolution.png.sha512 Outdated
@hjmjohnson hjmjohnson force-pushed the rebase/convolve-image-with-kernel-python branch 3 times, most recently from e90f9ba to dcab4b4 Compare June 14, 2026 21:48
@github-actions

github-actions Bot commented Jun 14, 2026

Copy link
Copy Markdown

Super-linter summary

Language Validation result
PYTHON_BLACK Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@hjmjohnson hjmjohnson force-pushed the rebase/convolve-image-with-kernel-python branch from dcab4b4 to 4f2332c Compare June 15, 2026 00:50
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

Super-linter summary

Language Validation result
PYTHON_BLACK Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@hjmjohnson hjmjohnson force-pushed the rebase/convolve-image-with-kernel-python branch from 4f2332c to 7e3abc9 Compare June 15, 2026 02:11
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

Super-linter summary

Language Validation result
PYTHON_BLACK Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@hjmjohnson hjmjohnson force-pushed the rebase/convolve-image-with-kernel-python branch from 7e3abc9 to d8d36b8 Compare June 15, 2026 11:54
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

Super-linter summary

Language Validation result
PYTHON_BLACK Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@hjmjohnson hjmjohnson force-pushed the rebase/convolve-image-with-kernel-python branch from d8d36b8 to f9cde89 Compare June 15, 2026 12:00
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

Super-linter summary

Language Validation result
PYTHON_BLACK Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@hjmjohnson hjmjohnson force-pushed the rebase/convolve-image-with-kernel-python branch from f9cde89 to 242b5d1 Compare June 15, 2026 14:36
@github-actions github-actions Bot added the type:Data Changes to example data (usually displayed images) label Jun 15, 2026
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

Super-linter summary

Language Validation result
PYTHON_BLACK Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@hjmjohnson @JaimeTorres1
COMP: Skip non-comparable Python baseline test for ConvolveImageWithK…
e8817df 
…ernel

The Python example emits the raw convolved image (512x342, grayscale),
while the shared C++ baseline is a QuickView render-window screenshot
(602x302, RGB). The auto-generated ConvolveImageWithKernelTestBaseline-
ComparisonPython test compared these and failed on the size mismatch.

Add a NO_PYTHON_COMPARISON option to compare_to_baseline() and use it
for ConvolveImageWithKernel so only the run-only Python test remains.

Co-Authored-By: Pranjal Sahu <23420081+PranjalSahu@users.noreply.github.com>
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

Super-linter summary

Language Validation result
PYTHON_BLACK Pass ✅

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown

🎉 Published on https://examples.itk.org as production
🚀 Deployed on https://6a305cc49c09710f6bea16b2--itkexamples.netlify.app

@github-actions github-actions Bot temporarily deployed to production June 15, 2026 20:13 Inactive
@github-actions github-actions Bot temporarily deployed to production June 15, 2026 20:13 Inactive
@hjmjohnson hjmjohnson merged commit 56b3ce0 into main Jun 15, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dzenanz dzenanz dzenanz left review comments

Assignees

No one assigned

Labels

area:Documentation Issues affecting the Documentation module area:Filtering Issues affecting the Filtering module language:Python Changes to Python examples type:Data Changes to example data (usually displayed images) type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hjmjohnson @dzenanz @PranjalSahu